Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the process of reading .seq files #301

Closed
wants to merge 2 commits into from

Conversation

beorostica
Copy link
Contributor

@beorostica beorostica commented Jan 23, 2024

This pull request is the continuation of the work done by @gabuzi in the pull request #238.
It is also intended to address the issue #224.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (e3107c1) 92.60% compared to head (efadc1a) 90.50%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   92.60%   90.50%   -2.11%     
==========================================
  Files          33       33              
  Lines        2245     2411     +166     
==========================================
+ Hits         2079     2182     +103     
- Misses        166      229      +63     
Flag Coverage Δ
base 92.00% <0.00%> (-0.68%) ⬇️
core 90.47% <ø> (ø)
files 83.84% <64.59%> (-8.51%) ⬇️
komamri 93.89% <ø> (ø)
plots 93.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
KomaMRICore/src/KomaMRICore.jl 100.00% <ø> (ø)
KomaMRIFiles/src/KomaMRIFiles.jl 100.00% <ø> (ø)
KomaMRIBase/src/datatypes/sequence/ADC.jl 92.50% <0.00%> (-2.38%) ⬇️
KomaMRIBase/src/datatypes/sequence/Delay.jl 85.71% <0.00%> (-14.29%) ⬇️
KomaMRIBase/src/datatypes/sequence/Grad.jl 89.83% <0.00%> (-1.55%) ⬇️
KomaMRIBase/src/datatypes/sequence/RF.jl 85.45% <0.00%> (-1.59%) ⬇️
KomaMRIBase/src/datatypes/Sequence.jl 91.31% <0.00%> (-0.60%) ⬇️
KomaMRIFiles/src/Sequence/Pulseq.jl 82.10% <64.59%> (-9.01%) ⬇️

@cncastillo
Copy link
Member

cncastillo commented Jan 27, 2024

No need to create a new pull for this. Continue in #238.

@cncastillo cncastillo closed this Jan 27, 2024
@cncastillo cncastillo deleted the seq-read-optimization branch January 27, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants