Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ArbitraryMotion (continuation) #408

Merged
merged 115 commits into from
Jun 27, 2024
Merged

Commits on May 31, 2024

  1. First commit

    pvillacorta committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5120dee View commit details
    Browse the repository at this point in the history
  2. Fix bugs and pass tests

    pvillacorta committed May 31, 2024
    Configuration menu
    Copy the full SHA
    87adbe0 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Configuration menu
    Copy the full SHA
    3506d03 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    60e5743 View commit details
    Browse the repository at this point in the history
  2. Simplify adapt functions

    pvillacorta committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9b2a9c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    1ee2bb8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b70ca80 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a387d22 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    97eb2a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    7c62afa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83e0527 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d282f9f View commit details
    Browse the repository at this point in the history
  4. Remove comments

    pvillacorta committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b82fa19 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    352ebbb View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. Configuration menu
    Copy the full SHA
    c8e5beb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8414916 View commit details
    Browse the repository at this point in the history
  3. Solve typo

    pvillacorta committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    49bf6a8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4d41071 View commit details
    Browse the repository at this point in the history
  5. Improve code coverage

    pvillacorta committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    c8a754b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    f044ede View commit details
    Browse the repository at this point in the history
  2. Add testset macro

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ed0ad5e View commit details
    Browse the repository at this point in the history
  3. Add specific identifiers

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9ef5d81 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4010c2d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    596379e View commit details
    Browse the repository at this point in the history
  6. Fix typo

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c9f0980 View commit details
    Browse the repository at this point in the history
  7. Remove collect

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    368cec2 View commit details
    Browse the repository at this point in the history
  8. Simplify range

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    5050c46 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9ab9abb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b8a2b83 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b4b2307 View commit details
    Browse the repository at this point in the history
  12. Change functions names

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1733ba6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ed7afd2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    cfeddb2 View commit details
    Browse the repository at this point in the history
  15. Recover return

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    47ccfc0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e10474b View commit details
    Browse the repository at this point in the history
  17. Remove K from tests

    pvillacorta committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    58756f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    8dfaf1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6134911 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c50da52 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a58485b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    115815f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eeaf970 View commit details
    Browse the repository at this point in the history
  7. Correct view bug

    pvillacorta committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2bce2e4 View commit details
    Browse the repository at this point in the history
  8. Dispatch on Val(Ns)

    pvillacorta committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    872d16a View commit details
    Browse the repository at this point in the history
  9. one -> oneunit

    pvillacorta committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7172839 View commit details
    Browse the repository at this point in the history
  10. fields -> phantom_fields

    pvillacorta committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5bc95ef View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    57149eb View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Configuration menu
    Copy the full SHA
    e040a0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    079a84c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c9a4dbb View commit details
    Browse the repository at this point in the history
  4. Remove TupleTools dependency, initialize_motion -> sort_motion (only …

    …needed by SimpleMotion)
    pvillacorta committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3a0862e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f1186c3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    37cdfae View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4df277b View commit details
    Browse the repository at this point in the history
  8. Solve bug

    pvillacorta committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ba92e75 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    10a4aa3 View commit details
    Browse the repository at this point in the history
  10. Solve bug

    pvillacorta committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3d45b55 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0310cab View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    1315be2 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Remove rangeT

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    de1da32 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    513ccf9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4107c1c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95a9fca View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58df3e6 View commit details
    Browse the repository at this point in the history
  6. More testing...

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ba4b468 View commit details
    Browse the repository at this point in the history
  7. More...

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3e16df7 View commit details
    Browse the repository at this point in the history
  8. t in GPU, id in CPU

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    87c7b4f View commit details
    Browse the repository at this point in the history
  9. Try with vectors

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    75918fe View commit details
    Browse the repository at this point in the history
  10. Fix bug

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fbac368 View commit details
    Browse the repository at this point in the history
  11. Another bug

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e7b5861 View commit details
    Browse the repository at this point in the history
  12. Let's try with LinRange

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fa97756 View commit details
    Browse the repository at this point in the history
  13. copyto!

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9288e04 View commit details
    Browse the repository at this point in the history
  14. Debug

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fe98989 View commit details
    Browse the repository at this point in the history
  15. Revert last change

    pvillacorta committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d12f81d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    db425e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Configuration menu
    Copy the full SHA
    409a719 View commit details
    Browse the repository at this point in the history
  2. Debugging prints

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    8085239 View commit details
    Browse the repository at this point in the history
  3. Remove @Supress temporarily

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ce91eb8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    81160e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eadf2fa View commit details
    Browse the repository at this point in the history
  6. More debugging

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    7112b64 View commit details
    Browse the repository at this point in the history
  7. Solve type conflict

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    aad423a View commit details
    Browse the repository at this point in the history
  8. Change conversion order

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    781c051 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d6f5da7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    eac3e87 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f1e3dee View commit details
    Browse the repository at this point in the history
  12. Try with ranges again

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    723b418 View commit details
    Browse the repository at this point in the history
  13. Back again to vectors

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0348a48 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    206fc37 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f7683a5 View commit details
    Browse the repository at this point in the history
  16. Recover @suppress

    pvillacorta committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c7f4a3b View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    10b814e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f4a85b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    431c164 View commit details
    Browse the repository at this point in the history
  4. Keep scatter for now

    pvillacorta committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cfa1165 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Configuration menu
    Copy the full SHA
    cbb1710 View commit details
    Browse the repository at this point in the history
  2. Solve bug, retry...

    pvillacorta committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f082e99 View commit details
    Browse the repository at this point in the history
  3. Check if it passes now

    pvillacorta committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f336659 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ade4138 View commit details
    Browse the repository at this point in the history
  5. Try again

    pvillacorta committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b9bfbfe View commit details
    Browse the repository at this point in the history
  6. Keep type matching

    pvillacorta committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    88e7451 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2ea2d98 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f06cf21 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f9908d7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    529a250 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    250f4f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1e8d8d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update KomaMRICore/test/runtests.jl

    Co-authored-by: Carlos Castillo Passi <cncastillo@uc.cl>
    pvillacorta and cncastillo authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ba82913 View commit details
    Browse the repository at this point in the history
  2. _utils.jl -> sorting.jl

    pvillacorta committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5c6fe49 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    639d9e4 View commit details
    Browse the repository at this point in the history
  4. All skipci except motions

    pvillacorta committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    df33c54 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4eaac2a View commit details
    Browse the repository at this point in the history
  6. Back to copyto!

    pvillacorta committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c26bd4b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c5a49ae View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5dcc8b8 View commit details
    Browse the repository at this point in the history