Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot phantom function #413

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Fix plot phantom function #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a58485b
Correct typos in SimpleMotionTypes docstrings
pvillacorta Jun 18, 2024
115815f
Delete `maxlog=1` and use `scattergl`
pvillacorta Jun 18, 2024
57149eb
Merge branch 'master' into fix-plot-phantom
pvillacorta Jun 18, 2024
37cdfae
Merge branch 'master' into fix-plot-phantom
cncastillo Jun 19, 2024
0f4a85b
Merge branch 'master' into fix-plot-phantom
pvillacorta Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion KomaMRIBase/src/datatypes/phantom/motion/simplemotion/HeartBeat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@doc raw"""
heartbeat = HeartBeat(t_start, t_end, dx, dy, dz)
heartbeat = HeartBeat(circumferential_strain, radial_strain, longitudinal_strain, t_start, t_end)

HeartBeat struct. It produces a heartbeat-like motion, characterised by three types of strain:
Circumferential, Radial and Longitudinal
Expand Down
2 changes: 1 addition & 1 deletion KomaMRIBase/src/datatypes/phantom/motion/simplemotion/PeriodicHeartBeat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@doc raw"""
periodic_heartbeat = PeriodicHeartBeat(t_start, t_end, dx, dy, dz)
periodic_heartbeat = PeriodicHeartBeat(circumferential_strain, radial_strain, longitudinal_strain, period, asymmetry)

HeartBeat struct. It produces a heartbeat-like motion, characterised by three types of strain:
Circumferential, Radial and Longitudinal
Expand Down
2 changes: 1 addition & 1 deletion KomaMRIBase/src/datatypes/phantom/motion/simplemotion/PeriodicRotation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@doc raw"""
periodic_rotation = PeriodicRotation(period, asymmetry, pitch, roll, yaw)
periodic_rotation = PeriodicRotation(pitch, roll, yaw, period, asymmetry)

PeriodicRotation motion struct. It produces a rotation of the phantom in the three axes:
x (pitch), y (roll), and z (yaw)
Expand Down
2 changes: 1 addition & 1 deletion KomaMRIBase/src/datatypes/phantom/motion/simplemotion/PeriodicTranslation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@doc raw"""
periodic_translation = PeriodicTranslation(period, asymmetry, dx, dy, dz)
periodic_translation = PeriodicTranslation(dx, dy, dz, period, asymmetry)

PeriodicTranslation motion struct. It produces a periodic translation of the phantom in the three directions x, y and z.
The amplitude of the oscillation will be defined by dx, dy and dz
Expand Down
2 changes: 1 addition & 1 deletion KomaMRIBase/src/datatypes/phantom/motion/simplemotion/Rotation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@doc raw"""
rotation = Rotation(t_start, t_end, pitch, roll, yaw)
rotation = Rotation(pitch, roll, yaw, t_start, t_end)

Rotation motion struct. It produces a rotation of the phantom in the three axes:
x (pitch), y (roll), and z (yaw).
Expand Down
2 changes: 1 addition & 1 deletion KomaMRIBase/src/datatypes/phantom/motion/simplemotion/Translation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@doc raw"""
translation = Translation(t_start, t_end, dx, dy, dz)
translation = Translation(dx, dy, dz, t_start, t_end)

Translation motion struct. It produces a linear translation of the phantom.
Its fields are the final displacements in the three axes (dx, dy, dz)
Expand Down
4 changes: 2 additions & 2 deletions KomaMRIPlots/src/ui/DisplayFunctions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,7 @@

if length(ph) > max_spins
ph = decimate_uniform_phantom(ph, max_spins)
@warn "For performance reasons, the number of displayed spins was capped to `max_spins`=$(max_spins)." maxlog=1
@warn "For performance reasons, the number of displayed spins was capped to `max_spins`=$(max_spins)."

Check warning on line 1080 in KomaMRIPlots/src/ui/DisplayFunctions.jl

View check run for this annotation

Codecov / codecov/patch

KomaMRIPlots/src/ui/DisplayFunctions.jl#L1080 

Added line #L1080 was not covered by tests
end

path = @__DIR__
Expand Down Expand Up @@ -1138,7 +1138,7 @@

if view_2d
trace = [
scatter(;
scattergl(;
x=(x[:, 1]) * 1e2,
y=(y[:, 1]) * 1e2,
mode="markers",
Expand Down