Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot_phantom_map for dynamic phantoms #490

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

pvillacorta
Copy link
Collaborator

@pvillacorta pvillacorta commented Sep 27, 2024

This should solve #407, although we are also getting rid of the play/pause buttons.

This PR:

  • Gets rid of the dispatch between static and dynamic phantoms when plotting
  • Sets max_spins keyarg default value to 20_000
  • Uses scattergl when view_2d is active
  • Removes the play/pause buttons

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.77%. Comparing base (48a5bbe) to head (790e1f2).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
KomaMRIPlots/src/ui/DisplayFunctions.jl 84.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   90.70%   90.77%   +0.06%     
==========================================
  Files          54       54              
  Lines        3046     3002      -44     
==========================================
- Hits         2763     2725      -38     
+ Misses        283      277       -6     
Flag Coverage Δ
base 87.07% <ø> (+0.27%) ⬆️
core 93.20% <ø> (ø)
files 91.69% <ø> (ø)
komamri 93.98% <100.00%> (ø)
plots 92.95% <84.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/KomaUI.jl 99.27% <100.00%> (ø)
KomaMRIPlots/src/ui/DisplayFunctions.jl 94.17% <84.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

@cncastillo cncastillo self-requested a review as a code owner September 27, 2024 19:46
@cncastillo cncastillo merged commit ab78766 into master Sep 27, 2024
18 checks passed
@cncastillo cncastillo deleted the fix-plot-phantom branch September 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KomaUI Plotting] obj_ui[] does not draw on first time updated. Need to press :rho or other option.
2 participants