Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid GPU runners for CPU jobs, and fix hanging CPU tests #502

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Avoid GPU runners for CPU jobs, and fix hanging CPU tests #502

merged 8 commits into from
Oct 31, 2024

Conversation

cncastillo
Copy link
Member

Fixes #501.

Moves CPU tests and benchmarks to the juliaecosystem queue, and reduces max time outs.

@cncastillo
Copy link
Member Author

cncastillo commented Oct 29, 2024 •
edited
Loading

CPU multi-threaded tests were hanging. The problem seems to be with the use of

julia_args=`--threads=auto`

Inside Pkg.test on Julia 1.11. I don't really understand why, I couldn't reproduce this locally. This could be related to Julia#54560. I modified the code so it now defines the env variable JULIA_NUM_THREADS instead.

@cncastillo cncastillo changed the title Avoid GPU runners for CPU jobs Avoid GPU runners for CPU jobs, and fix hanging CPU tests Oct 29, 2024
@cncastillo cncastillo merged commit 2884674 into master Oct 31, 2024
10 of 12 checks passed
@cncastillo cncastillo deleted the fix-buildkite-runners branch October 31, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't run CPU benchmarks on GPU workers
1 participant
@cncastillo