Adjust reset flag interpolation to trigger at jump #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with
FlowPath
, I realized that the interpolation of the reset flag is performed using theConstant{Previous}
option. This required thespin_reset
matrix to betrue
one time step before the jump, which doesn't make much sense.I believe it’s better for
spin_reset
to activate at the time node where the jump occurs, rather than the one before it. This approach simplifies phantom design and seems more intuitive.For a single spin, where the jump occurs when the spin exits at the top (
dz
= 4) and reenters at the bottom (dz
= -4):Previously, the phantom had to be designed like this:
Now:
So, this PR only changes
Previous
toNext
inoutflow_spin_reset!
.