Ease motion definition when only one motion is needed #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable handling and combination of `Motion`s and `MotionList`s: New `getindex` and `vcat` methods - Fix bugs with time nodes in `plot_phantom_map` - Fix bugs in the `export_motion` function in KomaMRIFiles - Test constructors for `Motion` and `FlowPath`
cncastillo
approved these changes
Dec 8, 2024
This was
linked to
issues
Dec 8, 2024
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #481.
I also take this chance to simplify how the folders and files within the
KomaMRIBase/src/motiondirectory were arranged.I will probably include here the tests for the
Motionconstructors, thus addressing #512 too.