Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited size of large assets in light mode #518

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

Stockless
Copy link
Collaborator

In light mode, some images got out of bounds. Fixed it by limiting it's maximum width in a @raw html block.

@cncastillo
Copy link
Member

And don't think this solves the core issue. Why is this happening only for light mode? Is there a problem with the CSS? Why is this problem not happening elsewhere?

@cncastillo
Copy link
Member

@Stockless has this been solved? I would try to approach it by using "inspect elements" and see which CSS is being overwritten in light mode.

@cncastillo
Copy link
Member

The solution is to change center-images.css to:

img {
  display: block; /* Ensures the image behaves as a block element */
  margin-left: auto;
  margin-right: auto;
}

@cncastillo cncastillo merged commit b113ee8 into JuliaHealth:master Dec 12, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants