Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit 'NadcsPerImage' to be at least 1 #527

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Limit 'NadcsPerImage' to be at least 1 #527

merged 1 commit into from
Dec 18, 2024
+1 −1

Conversation

Stockless
Copy link
Collaborator

@Stockless Stockless commented Dec 18, 2024 •
edited
Loading

As "NadcsPerImage" shouldn't ever be less than 1, it gets limited to be the at least 1. This implementation avoids a possible division by 0 in ISMRMRD.jl, Solving the Issue #409 :

if scan_counter % NadcsPerImage == 0 #For now only Nz is considered
    nz += 1 #another image
    scan_counter = 0 #reset counter
end

@Stockless Stockless linked an issue Dec 18, 2024 that may be closed by this pull request
An error of 'DivideError: integer division' occurs in the internal functions of simulate when using a sequence with spiral acquisition #409
Closed
@cncastillo
Copy link
Member

Thanks!

@cncastillo cncastillo merged commit 4ee83d2 into master Dec 18, 2024
16 of 23 checks passed
@cncastillo cncastillo deleted the recon-image-dimensions branch December 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Stockless @cncastillo