Dummy module now defines its own load/save instead of extending #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adds tests for keyword arguments
timholy
approved these changes
Nov 21, 2019
|
Thanks for the quick review! |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=====================================
Coverage 80% 80%
=====================================
Files 7 7
Lines 365 365
=====================================
Hits 292 292
Misses 73 73Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these changes were made in #161 but it looks like I accidentally reverted them in #78. Possibly a bad merge.
This also adds tests for keyword arguments in
loadandsave, making sure they get passed through to the handling package.