-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gzreadall(filename) and gzwrite(filename, data) #45
Conversation
Convenience functions to read/write directly from/to a named file. I'm doing a cleanup of my local stash of convenience functions and thought that these might be generally useful.
I have mixed feelings about this PR. On one hand, these seem like pretty useful functions. On the other, all other It's also the case that, while this library isn't deprecated, Libz.jl will probably give you a bit better performance. (Although it's function interface is rather nonstandard....) (Travis failures are unrelated.) |
See also samoconnor/Libz.jl@e95bdf1 |
closing in favour of BioJulia/Libz.jl#12 |
Despite my belief that I'm not as concerned about the |
Hi @kmsquire, Fair enough, it's probably easiest for someone with commit access to Libz to just paste in sorting like the following: readgz(filename::AbstractString) = gzopen(read, filename)
readgzstring(filename::AbstractString) = gzopen(readstring, filename)
writegz(filename::AbstractString, data) = gzopen(io -> write(io, data), filename, "w") |
Just curious, are the changes to |
I don't see why the new |
Anything that adds or changes functionality probably won't actually be backported--my understanding for Julia is that, by convention (and following Semantic Versioning), patch version number changes (changing (That, and backporting would probably inadvertently break someone's code when they target the new API and then try to run on a slightly older version of Julia.) But, they could be added to |
Indeed, @samoconnor, could you add the changes you made in JuliaLang/julia#14660 to Compat.jl? |
Convenience functions to read/write directly from/to a named file.
I'm doing a cleanup of my local stash of convenience functions and thought that these might be generally useful.