Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-literal bitstype immutables as type parameters #204

Closed
mbauman opened this issue Jan 7, 2015 · 1 comment
Closed

Allow non-literal bitstype immutables as type parameters #204

mbauman opened this issue Jan 7, 2015 · 1 comment

Comments

@mbauman
Copy link
Member

mbauman commented Jan 7, 2015

This is the unfinished work from #203: while types can now have arbitrary bitstype immutables as parameters, JLD does not support it.

Currently, the type is simply represented as a string, like Foo{Bar(1)}. Unfortunately, to construct the type from such a string, we'd have to eval the contents as the inverse of 5c7db4d does. Since Bar(1) is printed without its module name and could do anything, we cannot do this safely (even if Bar is a bits immutable, its constructor could do something nasty).

So I think we'll have to look into a new way of serializing type parameters as @simonster suggested in #203 (comment):

It seems that we either need to serialize the types/type parameters using JLD or come up with our own string representation of types that can be used to reconstruct them.
@mbauman mbauman mentioned this issue Jan 7, 2015
Merged
This was referenced Jan 27, 2015
Closed
Closed
@simonster simonster mentioned this issue Feb 28, 2015
Closed
simonster added a commit that referenced this issue Apr 24, 2015
@simonster
Temporarily disable type parameters that are themselves tuples
6bb6d9b 
On 0.4, we can't differentiate between these and tuples of types that
were saved by earlier versions of Julia. In earlier versions of Julia,
such tuples were not bits typed so they would not have been usable
anyway. We can revisit this when we're ready to change the file format
(perhaps as part of #204/#218)
simonster added a commit that referenced this issue Apr 25, 2015
@simonster
Temporarily disable type parameters that are themselves tuples
223e3f8 
On 0.4, we can't differentiate between these and tuples of types that
were saved by earlier versions of Julia. In earlier versions of Julia,
such tuples were not bits typed so they would not have been usable
anyway. We can revisit this when we're ready to change the file format
(perhaps as part of #204/#218)
simonster added a commit that referenced this issue Apr 25, 2015
@simonster
Temporarily disable type parameters that are themselves tuples
957605e 
On 0.4, we can't differentiate between these and tuples of types that
were saved by earlier versions of Julia. In earlier versions of Julia,
such tuples were not bits typed so they would not have been usable
anyway. We can revisit this when we're ready to change the file format
(perhaps as part of #204/#218)
@simonster simonster mentioned this issue Nov 8, 2016
Merged
@kleinhenz
Copy link
Contributor

closing since this seems like a JLD issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbauman @kleinhenz