Allow create_dataset to take a Type and Dataspace, Fix #1084 #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also expand definitions for dataspace with two positional arguments. Pin Blosc_jll to 1.21.2 if AVX2 is not detected. See Blosc/c-blosc#371
|
This is a bug fix and it's been a week, so I'm just going to merge this. |
|
LGTM |
musm
reviewed
Jul 11, 2023
|
|
||
| Construct a simple `Dataspace` for the given dimensions `dims`. The maximum | ||
| dimensions `maxdims` specifies the maximum possible size: `-1` can be used to | ||
| indicate unlimited dimensions. | ||
| """ | ||
| dataspace(sz::Dims{N}; max_dims::Union{Dims{N},Tuple{}}=()) where {N} = | ||
| _dataspace(sz, max_dims) | ||
| dataspace(sz::Dims{N}, max_dims::Union{Dims{N},Tuple{}}) where {N} = | ||
| _dataspace(sz, max_dims) | ||
| dataspace(dims::Tuple{Dims{N},Dims{N}}) where {N} = _dataspace(first(dims), last(dims)) |
There was a problem hiding this comment.
should we document these additional methods? These were added for additional flexibility?
There was a problem hiding this comment.
I think that we just implemented what wa already documented per #1084, but yes the documentation should reflect the new methods.
There was a problem hiding this comment.
I see the fix for adding the methods for create_dataset as per documentation, I was just curious on the new dataspace methods.
mkitti
added a commit
to mkitti/HDF5.jl
that referenced
this pull request
Aug 20, 2023
…uliaIO#1086) * Fix JuliaIO#1083 maxdims -> max_dims in dataspace documentation * Fix JuliaIO#1084, create_dataset with Type and Dataspace Also expand definitions for dataspace with two positional arguments. Pin Blosc_jll to 1.21.2 if AVX2 is not detected. See Blosc/c-blosc#371 * Formatter
mkitti
added a commit
that referenced
this pull request
Aug 23, 2023
* Fix _typed_load fast path for Julia 1.10 (currently nightly) (#1075) * Fix _typed_load fast path for Julia 1.10 (currently nightly) by thresholding on `1.10.0-DEV.1390` * Use `Libc.memcpy` after that threshold * Add initial support for H5Dchunk_iter (#1031) * Add initial support for H5Dchunk_iter * Implement h5d_chunk_iter_helper * Implement HDF5.get_all_chunk_info * Make tests pass via HDF5 1.14.0 * Apply formatting * Test filters with filter_mask via H5Dchunk_iter * Require functions to return an integer * Provide index based chunk iteration, rename to HDF5.get_chunk_info_all * Fix formatting * Fix documentation * Fix documentation * Improve testing * Always define _get_chunk_info_all_by_iter for documenter * Update src/datasets.jl Co-authored-by: Simon Byrne <simonbyrne@gmail.com> * Precompile get_chunk_info_all implementations before benchmarking * Fix documentation * Fix tests * Formatting --------- Co-authored-by: Simon Byrne <simonbyrne@gmail.com> * Simplify formatter check (#1078) This will display the diff, and return a non-zero exit code if there are changes * Fix #1083 maxdims -> max_dims in dataspace documentation (#1085) * Update light and dark logos for readme (#1087) * Fixup readme logo links and readme style (#1088) * Fixup readme logo links and readme style * Tweak * Tweak logo centering * Upload curves directly instead of fonts for logo independence (#1089) * Allow create_dataset to take a Type and Dataspace, Fix #1084 (#1086) * Fix #1083 maxdims -> max_dims in dataspace documentation * Fix #1084, create_dataset with Type and Dataspace Also expand definitions for dataspace with two positional arguments. Pin Blosc_jll to 1.21.2 if AVX2 is not detected. See Blosc/c-blosc#371 * Formatter * Attempt to fix documentation (#1091) * doc typo: attributes(parent), not attribute(parent) (#1095) * Fix tests for Julia 1.3 * Fix tests for Julia 1.3, Windows SZIP is broken again * Use static if block to fix 1.3 * Fix version and formatting * Fix tests * Bump version to 0.16.16 * Formatting --------- Co-authored-by: Simon Byrne <simonbyrne@gmail.com> Co-authored-by: Mustafa M <mus-m@outlook.com> Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxdimsormax_dimsindataspace()#1083 maxdims -> max_dims in dataspace documentationTypeandDataspaceincreate_dataset()#1084, create_dataset with Type and Dataspace