Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dict syntax in build.jl #216

Merged
merged 1 commit into from
Mar 8, 2015
Merged

fix dict syntax in build.jl #216

merged 1 commit into from
Mar 8, 2015

Conversation

rened
Copy link
Contributor

@rened rened commented Feb 24, 2015

No description provided.

@simonster
Copy link
Member

This doesn't appear to work. The Travis builds fail with:

LoadError: UndefVarError: @compat not defined

while loading /home/travis/.julia/v0.4/HDF5/deps/build.jl, in expression starting on line 25

@tkelman, you have any idea what to do about this deprecation warning? I'll work on the concatenation warnings.

@tkelman
Copy link
Contributor

tkelman commented Feb 28, 2015

Dunno, I think people have just been living with this one.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.38%) to 72.22% when pulling 21aa76f on rened:dictfix into f011e58 on timholy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.6% when pulling 21aa76f on rened:dictfix into f011e58 on timholy:master.

@rened
Copy link
Contributor Author

rened commented Mar 2, 2015

I tried to reverse the order of @compat and @BinDeps.install - it seems to work now.

@timholy
Copy link
Member

timholy commented Mar 8, 2015

Very nice, thanks!

timholy added a commit that referenced this pull request Mar 8, 2015
fix dict syntax in build.jl
@timholy timholy merged commit c9a0284 into JuliaIO:master Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants