Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us partway to fixing #50. @simonster , if you have time to review, I would greatly value your opinion. The most "controversial" aspect of this is that I decided to abandon my previous attempts to read fixed-size arrays by encoding the dimensions within an "instance" and instead decided to create a stub-type for each fixed-size array (with the dimensions encoded as parameters, e.g.,
FixedArray3{Float64, 3, 5, 7}
would correspond toArray{Float64,3}
of size(3,5,7)
. The stub types don't actually allocate any memory.The reason I went with the type-based approach is because the whole infrastructure around
hdf5_to_julia_eltype
etc is built on types rather than instances, and arrays-of-fixedarrays (as in the example file I added toreadremote
) seemed ugly if implemented with instances.But see if you agree.