Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ccall wrapper signature of h5a_iterate and h5l_iterate #817

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

jmert
Copy link
Contributor

@jmert jmert commented Feb 12, 2021

Addresses comment from #812 (comment).

Fixes #814.

@jmert jmert marked this pull request as ready for review February 12, 2021 20:45
@musm
Copy link
Member

musm commented Feb 12, 2021

LGTM

@jmert
Copy link
Contributor Author

jmert commented Feb 12, 2021

Change from having the op_data argument functionally exposed (and documented in the API reference) as ::Ptr{Cvoid} to ::Any is probably arguably a bug fix.

@jmert
Copy link
Contributor Author

jmert commented Feb 12, 2021

OK, CI passed on v1.4. I'll rebase to remove the CI change and push again.

@jmert jmert force-pushed the fixjl1.4_callbacks branch from bd37756 to 886579a Compare February 12, 2021 20:54
@musm
Copy link
Member

musm commented Feb 12, 2021

Thanks, I'll also make a new patch release with this fix.

@musm musm merged commit b267cf5 into JuliaIO:master Feb 12, 2021
@jmert jmert deleted the fixjl1.4_callbacks branch February 12, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error in Julia 1.4
2 participants