update to newest binary deps

[SimonDanisch]

this removed the fix in Libpngbuilder for windows symlink - since in theory, it should now work without..
But we should test this thoroughly on windows!
cc: @hhaensel

[SimonDanisch]

Huh, what's with FreeBSD, does that somehow not build at all?!

[hhaensel]

Strange!
It does build on Windows 7 without admin rights, but as far as I see, there are no symlinks in the windows binary ... ?
test ImageMagick passes with two warnings:

┌ Warning: Mapping to the storage type failed; perhaps your data had out-of-range values?
│ Try `map(clamp01nan, img)` to clamp values to a valid range.
└ @ ImageMagick C:\Users\m136270\.julia\packages\ImageMagick\gonx6\src\ImageMagick.jl:167
Test Summary: | Pass  Total
IO            |   35     35
extraProps = ["create-date", "date:create", "date:modify", "modify-date", "png:bKGD", "png:cHRM", "png:gAMA", "png:IHDR.
bit-depth-orig", "png:IHDR.bit_depth", "png:IHDR.color-type-orig", "png:IHDR.color_type", "png:IHDR.interlace_method", "
png:IHDR.width,height", "png:pHYs", "png:sRGB", "png:text"]
┌ Warning: Undefined property, possible names are "create-date","date:create","date:modify","modify-date","png:bKGD","pn
g:cHRM","png:gAMA","png:IHDR.bit-depth-orig","png:IHDR.bit_depth","png:IHDR.color-type-orig","png:IHDR.color_type","png:
IHDR.interlace_method","png:IHDR.width,height","png:pHYs","png:sRGB","png:text"
└ @ ImageMagick C:\Users\m136270\.julia\packages\ImageMagick\gonx6\src\libmagickwand.jl:342

[SimonDanisch]

 ErrorException("function save does not accept keyword arguments")

How can such an error happen, when it doesn't happen with the other CIs :D
Does it somehow install different versions of the dependencies or something like that?

[hhaensel]

Huh, what's with FreeBSD, does that somehow not build at all?!

I think its your deps.jl

const libwand = joinpath(dirname(@__FILE__), "usr\\bin\\libMagickWand-6.Q16-6.dll")

which should be

const libwand = joinpath(dirname(@__FILE__), "usr", "bin", "libMagickWand-6.Q16-6.dll")

[SimonDanisch]

But it doesn't complain about that anymore (that was fixed by updating the build script)... Now it's some weird other error ;)
Btw, BinaryProvider writes this, so maybe this needs a fix there? Definitely not nice to concat paths this way.

[hhaensel]

Grrrh,
@staticfloat was maybe right when he said that this replacement "\\"=>"\\\\"could be difficult ...
You could try to modify the replacement in BinaryProvider, I don't have user rights to create a branch

[hhaensel]

Just for my understanding: your commit always write deps removed the libwand error?
So need to worry about my fix in BinaryProvider then?

[hhaensel]

The errors of the different Julia versions are all different. Some have a timeout during download.
Maybe, there was an problem with the github server or with the virtual machine server?

[SimonDanisch]

Ok I have no idea about feebsd, but it seems like it was failing before...
Since this PR actually solves JuliaIO/FileIO.jl#229 we should think about merging this!

[SimonDanisch]

I'm going to merge this since it seems to work fine and the current tag is broken