Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(decode): support IO and in-memory data #13

Merged
merged 2 commits into from
Feb 3, 2022
Merged

feat(decode): support IO and in-memory data #13

merged 2 commits into from
Feb 3, 2022

Conversation

johnnychen94
Copy link
Member

closes #6

@johnnychen94
feat(decode): support IO and in-memory data
568dd36 
Instead of using C stdio and jpeg_stdio_src, this commit uses
jpeg_mem_src so that we can support IO and bytes data type for
jpeg_decode.

The testset is slightly re-organized and ImageMagick is removed
as a test dependency.
@johnnychen94
fix(decode): add integrity check
3444051 
Otherwise julia would direct exit
@johnnychen94 johnnychen94 added the enhancement New feature or request label Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #13 (3444051) into master (8de1547) will increase coverage by 2.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   87.58%   89.77%   +2.18%     
==========================================
  Files           4        4              
  Lines         145      176      +31     
==========================================
+ Hits          127      158      +31     
  Misses         18       18
Impacted Files Coverage Δ
src/decode.jl 96.87% <100.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de1547...3444051. Read the comment docs.

@johnnychen94 johnnychen94 merged commit abd540e into master Feb 3, 2022
@johnnychen94 johnnychen94 deleted the jc/decode_io branch February 3, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

decoding: support IO and in-memory
1 participant
@johnnychen94