Replace search(s, t) with something(findfirst(t, s), 0:-1)
#101
Conversation
DilumAluthge
requested review from
ararslan,
musm,
nalimilan,
SimonDanisch and
vtjnash
|
Note: |
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 30.21% 28.86% -1.35%
==========================================
Files 4 4
Lines 1026 1150 +124
==========================================
+ Hits 310 332 +22
- Misses 716 818 +102
Continue to review full report at Codecov.
|
|
Should I go ahead and merge and tag then? |
Yeah that might be good. Then I can finish fixing WinRPM. |
|
These changes look good to me. I'll wait until CI and if they pass will merge and tag. |
| @@ -22,7 +22,7 @@ wc = wrap_c.init( | |||
| clang_extraargs, | |||
| (th, h) -> | |||
| begin | |||
| if search(h, "expat") == 0:-1 | |||
| if something(findfirst("expat", h), 0:-1) == 0:-1 | |||
There was a problem hiding this comment.
This works, but it would be much more logical to write this instead:
if findfirst("expat", h) === nothingYou could even replace all this block with occursin("expat", h).
There was a problem hiding this comment.
Yeah I just replaced it with the exact suggestion from the deprecation warning that Julia 0.7 gave me, just to make sure I didn't break anything.
The
searchfunction has been removed from Julia. (It was deprecated in Julia 0.7 and removed in Julia 1.0).This pull request replaces all uses of
search(s::AbstractString, t::AbstractString)withsomething(findfirst(t, s), 0:-1).cc: @musm @vtjnash