Upgrade to 1.3+, use Expat_jll to vendor libexpat
#99
Conversation
staticfloat
force-pushed
the
sf/artifact
branch
from
e075dc6
to
219d6d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=========================================
Coverage ? 30.21%
=========================================
Files ? 4
Lines ? 1026
Branches ? 0
=========================================
Hits ? 310
Misses ? 716
Partials ? 0
Continue to review full report at Codecov.
|
|
Wow, that's quite the drop in coverage. |
Manifest.toml
Outdated
| @@ -0,0 +1,63 @@ | |||
| # This file is machine-generated - editing it directly is not advised | |||
|
|
|||
There was a problem hiding this comment.
Better not ship the Manifest!?
There was a problem hiding this comment.
Why? Bundling the manifest is useful.
There was a problem hiding this comment.
Is it? I've only had problems with it and thought it's a semi official recommendation ;)
There was a problem hiding this comment.
@staticfloat I had problems with CI failing on HDF5.jl due to the checked in Manifest.toml file getting picked up and screwing with the build. Had to get rid of it. Best to either delete or put it in the .gitignore.
|
Also this is awesome! I always hated the libexpat shipped dependency just to bootstrap Pkg |
|
Btw, I just recently run into search still being used in here: Line 1028 in 6fe0d71 That got removed from julia in 1.0... Not sure if we want to fix it here in this PR ;) |
|
I'm going to merge this if nobody is against it ;) |
Project.toml
Outdated
| @@ -0,0 +1,16 @@ | |||
| name = "LibExpat" | |||
| uuid = "522f3ed2-3f36-55e3-b6df-e94fee9b0c07" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
is it ok to set the version to this number?
There was a problem hiding this comment.
There was a problem hiding this comment.
I think you mean 0.5.0?
There was a problem hiding this comment.
Although maybe we should bump the version since this could be considered a big change.
There was a problem hiding this comment.
I'll let you guys bump the version number if you want afterwards.
This will allow Julia 1.3 to stop shipping
libexpatwith the distribution; the library will be dynamically downloaded and unpacked when needed.