Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibilities in MAT_v5.jl with v1.0.2 #104

Closed
wg030 opened this issue Nov 20, 2018 · 1 comment
Closed

Incompatibilities in MAT_v5.jl with v1.0.2 #104

wg030 opened this issue Nov 20, 2018 · 1 comment

Comments

@wg030
Copy link

wg030 commented Nov 20, 2018

When making my Julia code campatibile with the latest stable version 1.0.2, I have figured out some lines in "MAT_v5.jl" that were still not compatibile, so I have fixed them as follows:

Line 171: field_name_strings = Vector{String}(undef, n_fields)
Line 175: index = findfirst(isequal( 0), sname)
Line 193: data[field_name] = Array{Any}(undef, dimensions...)
Line 260: data = Vector{String}(undef, dimensions[1])

With these modifications at least my code works as before.

@mforets
Copy link
Contributor

mforets commented Dec 13, 2018

I had the same problem when I tried some benchmark suite that depends on MAT in a fresh Julia installation, and I found your suggestions useful 👍

This is of course a tiny fraction of PR #86. There was some discussion in that thread about splitting it out into smaller pieces. So i opened #106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants