Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compatibility issues #106

Merged
merged 3 commits into from
Dec 15, 2018
Merged

Fix some compatibility issues #106

merged 3 commits into from
Dec 15, 2018

Conversation

mforets
Copy link
Contributor

@mforets mforets commented Dec 13, 2018

Closes #104.

@yuyichao
Copy link
Collaborator

Lgtm as long as 0.6 is still working. (It doesn't seem that this is a complete fix). Should be able to handle with compact if not working already.

@mforets
Copy link
Contributor Author

mforets commented Dec 13, 2018

Lgtm as long as 0.6 is still working.

The tests in v0.6 now pass locally.

It doesn't seem that this is a complete fix

True. I just fixed some more, but tests in v1.0.2 do not yet pass.
FWIW, the error is:

$ julia1 --color=yes test/runtests.jl
ERROR: LoadError: LoadError: Data mismatch reading logical_mat from logical.mat (v6)

Got Base.ReinterpretArray{Bool,2,UInt8,Array{UInt8,2}}:

Bool[true false false; false true false; true false false]

Expected Array{Bool,2}:

Bool[true false false; false true false; true false false]

I don't plan to send a new commit; I guess it is related to these lines in @halleysfifthinc's PR, but i haven't checked.

@yuyichao
Copy link
Collaborator

It doesn't seem that this is a complete fix

That's only relevant for 0.6 compatibility. Not a complete fix isn't a problem at all. No need to put everything in. I can merge as long as CI on 0.6 pass. Feel free to ping. (Not gonna watch it....)

@yuyichao yuyichao merged commit 1c3675c into JuliaIO:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants