Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace call to finalize with GC.gc() to fix tests on julia 1.11 #53

Merged
merged 5 commits into from
May 30, 2024

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented May 29, 2024

In Julia 1.11 calling finalize on the Vector from mmap doesn't unmap, because the finalizer is now attached to the internal Memory. Ref: JuliaLang/julia#54210

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (20d6ae7) to head (5d20cb6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files           6        6           
  Lines         776      776           
=======================================
  Hits          773      773           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2 nhz2 marked this pull request as ready for review May 30, 2024 01:52
@nhz2 nhz2 merged commit 2ff4166 into main May 30, 2024
20 checks passed
@nhz2 nhz2 deleted the Don't-directly-call-finalize branch May 30, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant