-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests with ColorTypes 0.10 #174
Conversation
ColorTypes is used via ImageCore, and so was never explicitly tested for upgradability to v0.10. The old test relied on `convert(RGB{N0f8}, 0)` throwing an error, but it doesn't anymore.
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 91.65% 90.90% -0.75%
==========================================
Files 9 9
Lines 1222 1232 +10
==========================================
Hits 1120 1120
- Misses 102 112 +10
Continue to review full report at Codecov.
|
ColorTypes is used via ImageCore, and so was never explicitly tested for upgradability to v0.10. The old test relied on
convert(RGB{N0f8}, 0)
throwing an error, but it doesn't anymore.