-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix freqkernel #207
fix freqkernel #207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 91.07% 91.11% +0.03%
==========================================
Files 10 10
Lines 1412 1418 +6
==========================================
+ Hits 1286 1292 +6
Misses 126 126
Continue to review full report at Codecov.
|
Hi @johnnychen94 are you a maintainer here? This PR has been ready for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. It looks quite good, just a stylistic point (optional) and suggestion for testing your error conditions too.
I just learned about Aqua.jl and tested it out on ImageFiltering.jl and it reported that ImageMetadata is unused so I removed it from deps. This is a bit off topic from freqkernel but figured I'd include it in this PR anyway and see how it goes... |
Also addressing #208 with a 1-line fix. Hopefully. |
Very nice work, @JeffFessler. Thanks! |
I was AFK for the last two months so sorry for the inactivity. I've looked at the psf2otf source codes two years ago so I'm contaminated and thus can't review this PR (#81). Thank you both for the efforts. |
Addresses #206
The substance here is the changed lines with
wrapindex
and the corresponding added test.There is also a subtle point that the kernel needs to be supported in [-N/2, N/2-1) so I added checks for that too (handling both even and odd N cases). And some minor tweaking of docstrings.
FWIW, I'm teaching a graduate image processing course where I am trying to translate everything from Matlab to Julia so getting this
psf2tof
equivalent working is very desirable.