Cut allocations in padindex
#277
Merged
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 91.81% 91.86% +0.04%
==========================================
Files 12 12
Lines 1662 1672 +10
==========================================
+ Hits 1526 1536 +10
Misses 136 136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I believe the test failure is unrelated? |
|
Should we merge? Do you have merge rights? If not, I can add you to help here. |
|
Hi, I don't have merge rights currently, so that would be nice. |
|
Sent invitation. |
|
I will merge at the end of the week if I don't hear an objection. I can also bump the version if it's otherwise ready for a patch release. |
|
I just made a release yesterday - so this should be straightforward to merge and make a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
padindexresults in a large number of allocations due to multiple array creations and concatenations. This PR only creates a single array and values are copied into it.