Fix errors and depwarns on 0.6 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most important change is to broadcasting
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
- Coverage 98.95% 89.94% -9.01%
==========================================
Files 3 3
Lines 192 199 +7
==========================================
- Hits 190 179 -11
- Misses 2 20 +18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important change is to broadcasting. One surprise here was how
M .+ Mbehaved differently thanM .+ M2; the former is implemented by rewriting the function, so "broadcasting" gets passed a single array. This is insanely clever, makes certain things work on 0.6 that simply can't be allowed to work on 0.5, but also puzzled me for a good amount of time.