Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml #9

Merged
merged 7 commits into from
Oct 1, 2022
Merged

Update Project.toml #9

merged 7 commits into from
Oct 1, 2022

Conversation

RexWzh
Copy link
Member

@RexWzh RexWzh commented Oct 1, 2022

Sorry I forgot to add the dependencies, it seems that each package needs to specify dependencies, otherwise the ]st command will go wrong.

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 99.45% // Head: 100.00% // Increases project coverage by +0.54% 🎉

Coverage data is based on head (f99d09c) compared to base (547f795).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master        #9      +/-   ##
===========================================
+ Coverage   99.45%   100.00%   +0.54%     
===========================================
  Files           5         5              
  Lines         367       368       +1     
===========================================
+ Hits          365       368       +3     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
src/QRDecoders.jl 100.00% <100.00%> (ø)
src/detect.jl 100.00% <100.00%> (+7.14%) ⬆️
src/qrdecode.jl 100.00% <100.00%> (ø)
src/qrinfo.jl 100.00% <100.00%> (+1.05%) ⬆️
src/syndrome.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Images dependency might be too large, any chance we can get it smaller (e.g., ImageBase) in next release?

@RexWzh
Copy link
Member Author

RexWzh commented Oct 1, 2022

The Images dependency might be too large, any chance we can get it smaller (e.g., ImageBase) in next release?

Certainly!
I don't know much about package versions yet, only two functions are needed here:

  • load from FileIO
  • imresize from ImageTransformations

So it would be better to use these two packages instead?

Something like

[deps]
FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
ImageTransformations = "02fcd773-0e25-5acc-982a-7f6622650795"
QRCoders = "f42e9828-16f3-11ed-2883-9126170b272d"

[compat]
FileIO = "1"
QRCoders = "1"
ImageTransformations = "0.9"
julia = "1.3"

@johnnychen94
Copy link
Member

Because FileIO is a pure frontend, the backends ImageIO and/or ImageMagick are also needed.

@RexWzh RexWzh merged commit 64c5d5c into master Oct 1, 2022
@RexWzh RexWzh deleted the RexWzh-patch-1 branch October 4, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants