Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for anonymous nested record #223

Merged
merged 9 commits into from
Feb 27, 2019
Merged

Support for anonymous nested record #223

merged 9 commits into from
Feb 27, 2019

Conversation

Gnimuc
Copy link
Member

@Gnimuc Gnimuc commented Feb 24, 2019

Since Julia doesn't support defining nested structs:

struct Foo
    struct Bar
         b
    end
    x::Bar  # x can't see Bar
end

the workaround used here is to define a global hard-coded mangling "anonymous" struct and then treat it as a common struct when generating ASTs.

@Gnimuc Gnimuc mentioned this pull request Feb 24, 2019
@vchuravy
Copy link
Collaborator

I found two cases were this branch did mostly the right thing: #222 (comment)

@Gnimuc
Copy link
Member Author

Gnimuc commented Feb 25, 2019

For #224, should we generate code for __attribute__ enums with a warning message or not generate code at all?

@Gnimuc Gnimuc requested review from ihnorton and vchuravy February 26, 2019 01:07
Copy link
Collaborator

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side the generated files look reasonable.

@Gnimuc Gnimuc merged commit 3a4b7b4 into master Feb 27, 2019
@Gnimuc
Copy link
Member Author

Gnimuc commented Feb 27, 2019

merged and tagged v0.8.2.

@Gnimuc Gnimuc deleted the nested-record branch February 27, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for typedef union
2 participants