Bug fix in output_ignorelist #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A node should be ignored if its entire id matches the regular expression in the ignorelist, not if the regular expression occurs anywhere in the id.
|
Thanks! |
This was referenced Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current behavior, a node is skipped if its id contains the regex listed in
output_ignorelist. For example, in this header file:if
output_ignorelistcontains"X", then neither symbol will be output.Instead, it should be checked that the entire id matches the regex (and if the other behavior is desired, this can be accomplished with explicit wildcards,
".*X.*").