Fix unhandled non-field struct children #479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unhandled non-field child nodes were sometimes present in
children(cursor)
, and were already handled in printing but not in codegen, which triggered an assertion error atClang.jl/src/generator/print.jl
Line 119 in 30aaa5d
where
fields
built from the codegened expression had an extra field for a forward struct declaration.Here is an exemple header where the error appeared:
and codegen produced something like
Now we don't have that weird spurious
_ForwardA::_ForwardA
field.It happened to me while wrapping a larger header (
winuser.h
) using this pattern, but I couldn't come up with a minimal reproducer. For some reason,fields(Clang.getCursorType(cursor))
for_ExampleStruct
was empty in that larger header and Clang.jl fell back to usingchildren
to extract fields, while in any example I have tried for a minimal reproducerfields(Clang.getCursorType(cusor))
succeeded in returning the only field present as expected.