Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning about field_access_method_list not being portable #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamesWrigley
Copy link
Member

I may take a stab at fixing this later, but for now we can at least warn the users.

@JamesWrigley JamesWrigley self-assigned this Oct 26, 2024
@JamesWrigley
Copy link
Member Author

The failure on x86 nightly does not spark joy 👀 From looking at the testsets list I'm guessing it failed at the File test, but I don't see anything 32bit-specific that would fail. Could just be a spurious nightly failure given that the other x86 tests passed.

@Gnimuc
Copy link
Member

Gnimuc commented Oct 27, 2024

It would be better to add warnings in the codegen code so people can not ignore them.

This is what we do to warn people about platform-specific definitions in system headers.

show_info && @warn "[CollectDependentSystemNode]: found symbols in the system headers: $([n.id for (n,v) in x.dependents])"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants