Pja/fix julia home problems #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need a |
ararslan
reviewed
Jan 8, 2018
deps/build.jl
Outdated
| @@ -35,7 +35,7 @@ println("Tuning for julia installation at $BASE_JULIA_BIN with sources possibly | |||
| llvm_path = (Compat.Sys.isapple() && VersionNumber(Base.libllvm_version) >= v"3.8") ? "libLLVM" : "libLLVM-$(Base.libllvm_version)" | |||
|
|
|||
| llvm_lib_path = Libdl.dlpath(llvm_path) | |||
| old_cxx_abi = searchindex(open(read, llvm_lib_path),Vector{UInt8}("_ZN4llvm3sys16getProcessTripleEv"),0) != 0 | |||
| old_cxx_abi = findnext("_ZN4llvm3sys16getProcessTripleEv", String(open(read, llvm_lib_path)),0) != 0:-1 | |||
There was a problem hiding this comment.
String(open(read, llvm_lib_path)) could be written more clearly as read(llvm_lib_path, String), and the whole of it could be written more simply with contains:
old_cxx_abi = contains(read(llvm_lib_path, String), "_ZN4llvm3sys16getProcessTripleEv")
|
Thanks for the help @ararslan, sorry it took so long to get back to this. I think I have made the changes you requested. |
|
No problem. This looks good to me now, thanks! |
|
What's the status of this pull request? |
|
closed since this PR is obsoleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#25102 and JuliaLang/julia#24673 changed some things around. This seems to fix the build script.