Fix some v1.0 incompatibilities in show.jl. #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces lingering Voids with Nothings and fixes some string-related function usage.
ararslan
reviewed
Jan 3, 2019
src/show.jl
Outdated
| (isa(err, ErrorException) && contains(err.msg, "Could not find")) || rethrow(err) | ||
| return :( Base.show_datatype(io, typeof(x)); println(io," @0x", hex(convert(UInt,convert(Ptr{Void},x)),Sys.WORD_SIZE>>2)) ) | ||
| (isa(err, ErrorException) && occursin("Could not find", err.msg)) || rethrow(err) | ||
| return :( Base.show_datatype(io, typeof(x)); println(io," @0x", string(convert(UInt,convert(Ptr{Nothing},x)), base=16, pad=Sys.WORD_SIZE>>2)) ) |
There was a problem hiding this comment.
Ptr{Cvoid} reads a little nicer IMO (that's why that constant is defined) but otherwise these changes look good to me!
|
FYI, #400 also fixed these upgrading oversights. But it looks like keno just doesn't have any bandwidth to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces lingering
Voids withNothings and fixes some string-relatedfunction usage.