Add moar tests and fix isfreed()
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed the `SubString` test to actually use substrings with `@view`.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 83.10% 86.64% +3.54%
==========================================
Files 9 9
Lines 367 367
==========================================
+ Hits 305 318 +13
+ Misses 62 49 -13 ☔ View full report in Codecov by Sentry. |
|
Whoops, good catch! I'm surprised this hasn't caused crashes before now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through our coverage and adding some tests for low hanging fruit, and I noticed that the definition of
isfreed()might be wrong? I changed it in e5d75e9 to return whether the message handle is not ingc_protect; if I read the code correctly it will be held in the dict until ZMQ has finished with it and calledgc_free_fn(), which will delete it from the dict.