-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accuracy of sinpi
and cospi
#600
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 82.27% 84.76% +2.49%
==========================================
Files 23 23
Lines 2138 2035 -103
==========================================
- Hits 1759 1725 -34
+ Misses 379 310 -69 ☔ View full report in Codecov by Sentry. |
So it seems that the stack overflow comes from the fact that Specifically, https://github.com/JuliaIntervals/CRlibm.jl/blob/d212ba9154ade995bb6c330c51092c685a8ec432/src/CRlibm.jl#L152-L155 do not include the functions I may be missing something here, but why were these functions omitted? At first glance, I would have defined cc @dpsanders |
I fixed the StackOverflow issue for |
This PR is essentially a revival of the PR #421 which got forgotten unfortunately.
Closes #381; closes #412.
This PR also refactors the code in trigonometric.jl; the code is about 200 lines shorter.