Avoid broadcast over Q in tests #128
Conversation
Shouldn't my proposal yield the same result? I'm proposing this since broadcast over a `Q` matrix that has rather expensive `getindex` is somewhat an "abuse" of the fact that `AbstractQ <: AbstractMatrix`, see JuliaLang/julia#46196. This popped up in a nanosoldier run. I'm sure this is just a quick convenience usage here, in real-life code this would be horribly slow. In case it matters if you interval-lify before the product, one could replace this line by ```julia A = Symmetric(IA.Interval.(Matrix(Q)) * D * IA.Interval.(Matrix(Q'))) ```
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 17 17
Lines 642 642
=======================================
Hits 624 624
Misses 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thank you for the PR! Yes, I think you need to intervallify before taking the product, otherwise you couldn't ensure that the starting |
|
(now there seem to be some probably unrelated compatibility issues with ModelingToolKit, I'll try to have a look at those) |
|
Gentle bump. CI failures appear only on windows, independently from the Julia version used. |
|
yes you are right, the failures seem unrelated. I'm merging this and I'll address that in a separate PR. |
PR description
Shouldn't my proposal yield the same result? I'm proposing this since broadcast over a
Qmatrix that has rather expensivegetindexis somewhat an "abuse" of the fact thatAbstractQ <: AbstractMatrix, see JuliaLang/julia#46196. This popped up in a nanosoldier run. I'm sure this is just a quick convenience usage here, in real-life code this would be horribly slow.In case it matters if you interval-lify before the product, one could replace this line by