-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to the docs page #98
Conversation
This PR is only an update to the docs. As you may know, Documenter has a feature to push a preview of the docs if you set
I always forget that trick :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, @mforets!
I left a comment about the wording, which sounds better to me, but be aware that I'm not a native English speaker...
In addition, I'd like to suggest to use push_preview = true
within the deploydocs
function (in docs/make.jl
). It allows to have a preview (online) of the docs; see this for the relevant documentation. (This may make life easier for #99.)
f4dcf5e
to
24a0746
Compare
@lbenet I've updated this branch with master, however i'm not sure if docs preview will work because the PR is made from my fork (I don't have rights to make it from JuliaIntervals). |
Thanks a lot; I'll take a look on them later... I think you need to rebase to master (and push again), since #100 has been merged. this should make possible to see the preview of the docs. |
yes, i did just that. about my comment on the fork is about this Note:
|
Mmmm... you are right. Since the proposed changes LGTM, I guess we can simply go ahead and merge them. Is this ready? |
from my side it is ready 👌 |
Thanks a lot @mforets!! Merging. |
This PR brings the examples script (see here) to the main docs page.
I may contribute w/other subsections to that page (example use cases that come up frequently on the issues list of this repo / on Discourse), but we can go in stages.. :)