Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something with tagging is broken in 1.4 #165

Closed
KristofferC opened this issue Jan 28, 2020 · 1 comment
Closed

Something with tagging is broken in 1.4 #165

KristofferC opened this issue Jan 28, 2020 · 1 comment

Comments

@KristofferC
Copy link
Contributor

The tests now fail on 1.4 with e.g.

@context VATupleCtx
x = rand(5)
ctx = enabletagging(VATupleCtx(), 1)
result = @run overdub(ctx, broadcast, sin, x)

with

ERROR: MethodError: no method matching iterate(::Tuple{Array{Float64,1}}, ::Tuple{Array{Float64,1},Int64})
Closest candidates are:
  iterate(::Core.SimpleVector, ::Any) at essentials.jl:603
  iterate(::ExponentialBackOff, ::Any) at error.jl:253
  iterate(::Base.MethodList, ::Any...) at reflection.jl:854
  ...
Stacktrace:
 [1] overdub(::Cassette.Context{nametype(VATupleCtx),Nothing,Cassette.Tag{nametype(VATupleCtx),0xfddc2783aa6f0228,Nothing},Cassette.var"##PassType#255",IdDict{Module,Dict{Symbol,Cassette.BindingMeta}},Nothing}, ::typeof(Core._apply_iterate), ::typeof(iterate), ::Tuple{typeof(Base.Broadcast.broadcasted),Tuple{typeof(sin)},Tuple{Array{Float64,1}}}) at /home/kc/JuliaPkgs/Cassette.jl/src/context.jl:264
 [2] overdub(::Cassette.Context{nametype(VATupleCtx),Nothing,Cassette.Tag{nametype(VATupleCtx),0xfddc2783aa6f0228,Nothing},Cassette.var"##PassType#255",IdDict{Module,Dict{Symbol,Cassette.BindingMeta}},Nothing}, ::Tuple{typeof(broadcast),typeof(sin),Array{Float64,1}}) at broadcast.jl:758

It seems this got introduced in #158.

@vchuravy
Copy link
Member

Fixed in #172, but also the reason why overdubbing iterate is not enabled yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants