Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle _apply_iterate handling, but disable overdubbing of iterf in _apply_iterate #172

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Handle _apply_iterate handling, but disable overdubbing of iterf in _apply_iterate #172

merged 3 commits into from
Apr 20, 2020

Conversation

vchuravy
Copy link
Member

No description provided.

@Roger-luo
Copy link
Contributor

@oxinabox I feel this solves oxinabox/AutoPreallocation.jl#17 ? it seems apply_iterate was not handled correctly there?

@vchuravy vchuravy changed the title Disable apply_iterate handling Handle _apply_iterate handling, but disable overdubbing of iterf in _apply_iterate Apr 20, 2020
@vchuravy
Copy link
Member Author

Yeah the VACtx test stumped me. So I disabled overdubbing of iterf for now. There are still two other regressions, but at least this should unbreak Cassette on 1.4

@vchuravy vchuravy merged commit bd72542 into master Apr 20, 2020
@vchuravy vchuravy deleted the vc/disable_apply_iterate branch April 20, 2020 03:43
@KristofferC
Copy link
Contributor

Wasn't the whole point of introducing apply_iterate to be able to overdub the iterate in Core.apply?

@vchuravy
Copy link
Member Author

Yes, this PR doesn't address that, but it correctly deals with apply_iterate in all other situations and returns the status quo for Cassette to 1.4.

Activating the overdubbing of iterate breaks more things so that requires another look.

This was referenced Apr 20, 2020
Closed
Closed
Closed
@christopher-dG christopher-dG mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasonProtter MasonProtter MasonProtter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vchuravy @Roger-luo @KristofferC @MasonProtter