Add (sp)diagm pair constructors

README.md

@@ -180,6 +180,8 @@ Currently, the `@compat` macro supports the following syntaxes:
 
 * `*(::Union{Char,AbstractString},::Union{Char,AbstractString})` concatenation. ([#22512])
 
+* `diagm` and `spdiagm` accept pairs mapping diagonals to vectors ([#24047], [#23757])
+
 ## Renaming
 
 
@@ -343,7 +345,9 @@ includes this fix. Find the minimum version from there.
 [#23427]: https://github.com/JuliaLang/julia/issues/23427
 [#23570]: https://github.com/JuliaLang/julia/issues/23570
 [#23666]: https://github.com/JuliaLang/julia/issues/23666
+[#23757]: https://github.com/JuliaLang/julia/issues/23757
 [#23812]: https://github.com/JuliaLang/julia/issues/23812
 [#23931]: https://github.com/JuliaLang/julia/issues/23931
+[#24047]: https://github.com/JuliaLang/julia/issues/24047
 [#24282]: https://github.com/JuliaLang/julia/issues/24282
 [#22512]: https://github.com/JuliaLang/julia/issues/22532

src/Compat.jl

@@ -715,6 +715,34 @@ end
     export BitSet
 end
 
+# 0.7.0-DEV.2116
+@static if VERSION < v"0.7.0-DEV.2116"
+    import Base.spdiagm
+    if VERSION >= v"0.6.0"
+        include_string(@__MODULE__, """
+            spdiagm(kv::Pair{<:Integer,<:AbstractArray}...) = spdiagm(last.(kv), first.(kv))
+        """)
+    else
+        include_string(@__MODULE__, """
+            spdiagm{I<:Integer,A<:AbstractArray}(kv::Pair{I,A}...) = spdiagm(last.(kv), first.(kv))
+        """)
+    end
+end
+
+# 0.7.0-DEV.2161
+@static if VERSION < v"0.7.0-DEV.2161"
+    import Base.diagm
+    if VERSION >= v"0.6.0"
+        include_string(@__MODULE__, """
+            diagm(kv::Pair{<:Integer,<:AbstractArray}...) = diagm(last.(kv), first.(kv))
+        """)
+    else
+        include_string(@__MODULE__, """
+            diagm{I<:Integer,A<:AbstractArray}(kv::Pair{I,A}...) = spdiag(last.(kv), first.(kv))
+        """)
+    end
+end
+
 include("deprecated.jl")
 
 end # module Compat

test/runtests.jl

@@ -853,6 +853,12 @@ end
 # 0.7
 @test 1 in BitSet(1:10)
 
+# 0.7
+@test diagm(0 => ones(2), -1 => ones(2)) == [1.0 0.0 0.0; 1.0 1.0 0.0; 0.0 1.0 0.0]
+@test diagm(0 => ones(2), 1 => ones(2)) == [1.0 1.0 0.0; 0.0 1.0 1.0; 0.0 0.0 0.0]
+@test spdiagm(0 => ones(2), -1 => ones(2)) == [1.0 0.0 0.0; 1.0 1.0 0.0; 0.0 1.0 0.0]
+@test spdiagm(0 => ones(2), 1 => ones(2)) == [1.0 1.0 0.0; 0.0 1.0 1.0; 0.0 0.0 0.0]
+
 if VERSION < v"0.6.0"
     include("deprecated.jl")
 end