Remove at-compat for Nullable construction

Was added in #287, now obsolete as no longer required on minimum 
supported Julia version 0.6.

README.md

@@ -53,8 +53,6 @@ Currently, the `@compat` macro supports the following syntaxes:
 
 * `@compat(get(io, s, false))`, with `s` equal to `:limit`, `:compact` or `:multiline`, to detect the corresponding print settings (performs useful work only on Julia 0.5, defaults to `false` otherwise)
 
-* `@compat Nullable(value, hasvalue)` to handle the switch from the `Nullable` `:isnull` field to `:hasvalue` field ([#18510])
-
 * `@compat x .= y` converts to an in-place assignment to `x` (via `broadcast!`) ([#17510]).
  However, beware that `.=` in Julia 0.4 has the precedence of `==`, not of assignment `=`, so if the right-hand-side `y`
  includes expressions with lower precedence than `==` you should enclose it in parentheses `x .= (y)` to ensure the
@@ -529,7 +527,6 @@ includes this fix. Find the minimum version from there.
 [#18082]: https://github.com/JuliaLang/julia/issues/18082
 [#18380]: https://github.com/JuliaLang/julia/issues/18380
 [#18484]: https://github.com/JuliaLang/julia/issues/18484
-[#18510]: https://github.com/JuliaLang/julia/issues/18510
 [#18629]: https://github.com/JuliaLang/julia/issues/18629
 [#18727]: https://github.com/JuliaLang/julia/issues/18727
 [#18977]: https://github.com/JuliaLang/julia/issues/18977

src/Compat.jl

@@ -169,13 +169,6 @@ end
  Base.Broadcast.broadcast{N}(f, t::NTuple{N}, ts::Vararg{NTuple{N}}) = map(f, t, ts...)
 end
 
-# julia#18510
-if VERSION < v"0.6.0-dev.826"
- _Nullable_field2(x) = !x
-else
- _Nullable_field2(x) = x
-end
-
 # julia#18484
 @static if VERSION < v"0.6.0-dev.848"
  unsafe_get(x::Nullable) = x.value

src/compatmacro.jl

@@ -32,10 +32,6 @@ symbol2kw(arg) = arg
 function _compat(ex::Expr)
  if ex.head === :call
  f = ex.args[1]
- if VERSION < v"0.6.0-dev.826" && length(ex.args) == 3 && # julia#18510
- istopsymbol(withincurly(ex.args[1]), :Base, :Nullable)
- ex = Expr(:call, f, ex.args[2], Expr(:call, :(Compat._Nullable_field2), ex.args[3]))
- end
  if !isdefined(Base, :UndefKeywordError) && length(ex.args) > 1 && isexpr(ex.args[2], :parameters)
  params = ex.args[2]
  params.args = map(symbol2kw, params.args)

test/runtests.jl

@@ -192,41 +192,12 @@ if VERSION < v"0.7.0-DEV.3017"
  UInt8,
  ]
  for T in types
- # julia#18510, Nullable constructors
- x = @compat Nullable(one(T), true)
- @test isnull(x) === false
- @test isa(x.value, T)
- @test eltype(x) === T
-
- x = @compat Nullable{T}(one(T), true)
- y = @compat Nullable{Any}(one(T), true)
- @test isnull(x) === false
- @test isnull(y) === false
- @test isa(x.value, T)
- @test eltype(x) === T
- @test eltype(y) === Any
-
- x = @compat Nullable{T}(one(T), false)
- y = @compat Nullable{Any}(one(T), false)
- @test isnull(x) === true
- @test isnull(y) === true
- @test eltype(x) === T
- @test eltype(y) === Any
-
- x = @compat Nullable(one(T), false)
- @test isnull(x) === true
- @test eltype(x) === T
-
- x = @compat Nullable{T}()
- @test isnull(x) === true
- @test eltype(x) === T
-
  # julia#18484, generic isnull, unsafe_get
  a = one(T)
- x = @compat Nullable(a, true)
+ x = Nullable(a, true)
  @test isequal(unsafe_get(x), a)
 
- x = @compat Nullable{Array{T}}()
+ x = Nullable{Array{T}}()
  @test_throws UndefRefError unsafe_get(x)
  end
 end