Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chksquare is now called checksquare #168

Closed
KristofferC opened this issue Feb 5, 2016 · 8 comments
Closed

chksquare is now called checksquare #168

KristofferC opened this issue Feb 5, 2016 · 8 comments

Comments

@KristofferC
Copy link
Member

JuliaLang/julia#14601

@KristofferC
Copy link
Member Author

I can fix it if I knew how to get the build number from the PR.

Is it the same as the one in the Travis log for the PR or does it depend on when it is merged?

@nalimilan
Copy link
Member

@stevengj
Copy link
Member

stevengj commented Feb 5, 2016

VERSION >= v"0.5.0-dev+9476"

@KristofferC
Copy link
Member Author

I get:

$ ~/.julia/v0.5/Compat/bin/version.sh 0a1a612407fd53c03593faa51cb643672893151c
0.4.0-dev+2058

where I used the merge commit: JuliaLang/julia@0a1a612

Anyway, it seems like you can't create a new binding inside a module from another module and since chksquare wasn't exported I'm having some troubles...

@yuyichao
Copy link
Contributor

yuyichao commented Feb 5, 2016

You can create new binding from another module, use eval(module, ...) or module.eval(...).

And I believe the common practice in Compat for this is to define it as Compat.foo instead.

@stevengj
Copy link
Member

stevengj commented Feb 5, 2016

@KristofferC, I used the same commit and script and I got +9476, not 2058; I'm not sure why you're getting a different number -- are you not looking at the latest master tree of Julia? (The 0.4.0 is simply wrong, since this commit is in the 0.5 tree.)

@yuyichao
Copy link
Contributor

yuyichao commented Feb 5, 2016

The 0.4.0 is due to #151

@KristofferC
Copy link
Member Author

Thanks @andreasnoack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants