Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fate of qr #556

Closed
martinholters opened this issue May 24, 2018 · 1 comment
Closed

Fate of qr #556

martinholters opened this issue May 24, 2018 · 1 comment

Comments

@martinholters
Copy link
Member

From our README:

  • Compat.qr takes pivot as a Val instance and keyword argument full ([#22475], [#24279]).

And we have these tests:

Compat.jl/test/runtests.jl

Lines 1676 to 1695 in 2a82221

let A = [1 2; 1 2; 1 2]
f = Compat.qr(A, Val(false), full=false)
@test f == Compat.qr(A, Val(false))
@test length(f) == 2
@test size(f[1]) == (3, 2)
@test f[1] * f[2] A
f = Compat.qr(A, Val(false), full=true)
@test length(f) == 2
@test size(f[1]) == (3, 3)
@test f[1] * [f[2]; [0 0]] A
f = Compat.qr(A, Val(true), full=false)
@test f == Compat.qr(A, Val(true))
@test length(f) == 3
@test size(f[1]) == (3, 2)
@test f[1] * f[2] A[:,f[3]]
f = Compat.qr(A, Val(true), full=true)
@test length(f) == 3
@test size(f[1]) == (3, 3)
@test f[1] * [f[2]; [0 0]] A[:,f[3]]
end

But in JuliaLang/julia#27212 the LinearAlgebra API has been changed, qr doesn't take a full (thin in 0.6) keyword anymore, making these tests fail. Instead, both the "full" and the "thin" representation can be obtained from the returned object.

Ideally, we provide a qr that does the same and deprecate the current method to that. But I have no idea whether that is feasible.

@Sacha0
Copy link
Member

Sacha0 commented May 24, 2018

I err to agreeing with @fredrikekre in #555 (comment), i.e. simply versioning the tests and moving on. Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants