Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test that Pkg exports add #555

Merged
merged 1 commit into from
May 28, 2018
Merged

Don't test that Pkg exports add #555

merged 1 commit into from
May 28, 2018

Conversation

martinholters
Copy link
Member

Pkg3 still defines add, but doesn't export it anymore.

Minor follow-up to #551.

Pkg3 still defines `add`, but doesn't export it anymore.
@martinholters
Copy link
Member Author

Remaining test failures are due to JuliaLang/julia#27212. What do we do with those? CC @Sacha0

@fredrikekre
Copy link
Member

What is the failure?

@martinholters
Copy link
Member Author

ERROR: LoadError: WARNING: Base.qr is deprecated: it has been moved to the standard library package `LinearAlgebra`.
Add `using LinearAlgebra` to your imports.
 in module Base
MethodError: no method matching qr(::Array{Int64,2}, ::Val{false}; full=false)
Closest candidates are:
  qr(::AbstractArray{T,2}, ::Any) where T at usr/share/julia/stdlib/v0.7/LinearAlgebra/src/qr.jl:335 got unsupported keyword argument "full"
  qr(::AbstractArray{T,2}) where T at usr/share/julia/stdlib/v0.7/LinearAlgebra/src/qr.jl:340 got unsupported keyword argument "full"
Stacktrace:
 [1] top-level scope at Compat/test/runtests.jl:1677

It's the diappearance of the full keyword.

@fredrikekre
Copy link
Member

Perhaps we can just version that test then.

@martinholters
Copy link
Member Author

martinholters commented May 24, 2018

Sure, we could do that to get the tests pass. But providing this qr method on 0.6 only is of little use. It won't help with the migration to 0.7 at all. Ideally, we should probably deprecate the full keyword to ... and this is where it gets tricky. I'll open an issue (EDIT: #556) for the discussion, it doesn't really belong here.

@Sacha0 Sacha0 mentioned this pull request May 24, 2018
@martinholters martinholters merged commit 6a97476 into master May 28, 2018
@martinholters martinholters deleted the mh/pkg_add branch May 28, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants