Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for cat #612

Closed
galenlynch opened this issue Aug 12, 2018 · 0 comments
Closed

No support for cat #612

galenlynch opened this issue Aug 12, 2018 · 0 comments

Comments

@galenlynch
Copy link
Contributor

In 0.7, cat requires the dims keyword (#27100), but Compat.cat does not seem to work.

In Julia 0.6:

julia> cat(1, [1, 2, 3], [4, 5]) # 0.6 style call
5-element Array{Int64,1}:
 1
 2
 3
 4
 5

julia> using Compat
julia> Compat.cat([1, 2, 3], [4, 5], dims = 1) # 0.7 style call
ERROR: function cat does not accept keyword arguments
julia> @compat cat([1, 2, 3], [4, 5], dims = 1)
ERROR: function cat does not accept keyword arguments
galenlynch added a commit to galenlynch/Compat.jl that referenced this issue Aug 12, 2018
@galenlynch
Add compatibility for cat with dims kw argument
5e21a79 
cat(dims, Xs...) was deprecated to cat(Xs..., dims=dim) in [#27163], but as
described in JuliaLang#612 support for the new signature is missing in Compat.

Fixes JuliaLang#612

[#27163]: https://github.com/JuliaLang/julia/issue/27163
@galenlynch galenlynch mentioned this issue Aug 12, 2018
Merged
galenlynch added a commit to galenlynch/Compat.jl that referenced this issue Aug 16, 2018
@galenlynch
Add compatibility for cat with dims kw argument
9d629d1 
cat(dims, Xs...) was deprecated to cat(Xs...; dims=dim) in [#27163], but as
described in JuliaLang#612 support for the new signature is missing in Compat.

Fixes JuliaLang#612

[#27163]: https://github.com/JuliaLang/julia/issue/27163
martinholters pushed a commit that referenced this issue Aug 22, 2018
@galenlynch @martinholters
Add compatibility for cat with dims kw argument (#613)
5b939bf 
* Add compatibility for cat with dims kw argument

cat(dims, Xs...) was deprecated to cat(Xs...; dims=dim) in [#27163], but as
described in #612 support for the new signature is missing in Compat.

Fixes #612

[#27163]: https://github.com/JuliaLang/julia/issue/27163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@galenlynch