Provide promote_eltype_op #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't worry all that much about 0.3. Only a few packages are actively tagging new versions that support it. We haven't formally done so yet, but I anticipate "freezing" metadata for new package tags that support Julia 0.3 shortly after 0.5 comes out, though with a possibility for exceptions on a case-by-case basis. So the minimal thing you're doing here for now seems fine to me. |
martinholters
changed the title
|
Will merge later if no one objects. |
|
@martinholters Needs a rebase. |
martinholters
force-pushed
the
promote_eltype_op
branch
from
17798db
to
fd5c336
Compare
|
Ok, rebased. |
|
Someone care merging this? |
This was referenced Jul 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed due to JuliaLang/julia#17398.
For Julia 0.3, which lacks
promote_op, the definition is questionable. Maybe better only providepromote_eltype_opfor Julia 0.4?