Add Dates.canonicalize(::Period)
#726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nickrobinson251
commented
Oct 15, 2020
nickrobinson251
commented
- Added to Dates stdlib in Added canonicalize for Periods julia#37391
|
JuliaLang/julia#37391 brings some more tests. Would it make sense to also include them here? |
🤷♂️ I can bring them across if you like? I didn't since one test is enough to test the dispatch this PR adds (and those other tests are testing that the |
|
Yes, I think I'd prefer to bring them along. We can easily afford the extra run-time that costs and it would help catch any nasty surprises. |
nickrobinson251
force-pushed
the
npr/period-canonicalize
branch
from
ae39754
to
972110e
Compare
|
Cool :) i've brought over all the tests from the original PR and rebased to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.