Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port implicit named tuple and keyword argument names #747

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

omus
Copy link
Member

@omus omus commented Jul 28, 2021

Fixes #699. I implemented this without noticing that issue so this implementation was created independently from the mentioned package

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #747 (38e4efe) into master (aae32f1) will increase coverage by 0.14%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   81.67%   81.81%   +0.14%     
==========================================
  Files           4        4              
  Lines         513      528      +15     
==========================================
+ Hits          419      432      +13     
- Misses         94       96       +2     
Impacted Files Coverage Δ
src/compatmacro.jl 92.30% <86.66%> (-2.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae32f1...38e4efe. Read the comment docs.

@omus
Copy link
Member Author

omus commented Jul 28, 2021

Rebased to use the fix for #745

README.md Outdated Show resolved Hide resolved
@omus omus merged commit 28ac4ef into master Jul 28, 2021
@omus omus deleted the cv/implicit-keywords branch July 28, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit named tuple and keyword argument names
1 participant