Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allequal #766

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Add allequal #766

merged 1 commit into from
Mar 7, 2022

Conversation

mcabbott
Copy link
Contributor

This adds JuliaLang/julia#43354, which is in Julia 1.8

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #766 (177f169) into master (a2de107) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
+ Coverage   78.90%   79.00%   +0.09%     
==========================================
  Files           4        4              
  Lines         659      662       +3     
==========================================
+ Hits          520      523       +3     
  Misses        139      139              
Impacted Files Coverage Δ
src/Compat.jl 79.03% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2de107...177f169. Read the comment docs.

@mcabbott
Copy link
Contributor Author

mcabbott commented Mar 5, 2022

Bump, can this be merged?

@martinholters martinholters merged commit fa274f7 into JuliaLang:master Mar 7, 2022
@mcabbott mcabbott deleted the allequal branch March 7, 2022 12:35
@mcabbott
Copy link
Contributor Author

BTW, using this seems to cause JuliaDiff/ChainRules.jl#598 . I've no idea why, though.

@martinholters
Copy link
Member

I have no idea what's going on, but JuliaDiff/ChainRules.jl#598 (comment) says:

This wasn't an issue with Compat either, but with an older version of JuliaFormatter in my startup.jl!

And I failed to reproduce the problem. If someone can come up with a reproducer, I'm willing to look at it, but I doubt it's Compat's fault.

@mcabbott
Copy link
Contributor Author

Thanks for looking. I can't reproduce it either, but just wondered if you (or anyone) had ever seen something like this. I see nothing wrong with what either package is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants